PropertyBeanSetter fails to set DataSource#url for some databases

[brmeyer]

Slightly older versions of H2 provide JdbcDataSource#setURL, but not JdbcDataSource#setUrl. That was corrected in a recent revision, however it will cause issues for many Hibernate users. Could PropertyBeanSetter#setTargetFromProperties be improved to handle crappy JDBC impls? ;)

I'm including a workaround in hibernate-hikaricp, for now.

Thanks!

[brettwooldridge]

Two things. Because the PropertyBeanSetter is purely reflection based, URL would work as a property. However, probably the cleanest way for me to address this that follows the principle of least astonishment is to have the PropertyBeanSetter first try the property as specified, and if the setter is not found, try to find the method by upper-casing the property name. What do you think?

[brmeyer]

Yep, exactly what I had in mind! And you're correct -- my workaround sets URL as a property in hibernate-hikaricp. This may only be an issue for the specific versions of H2, but I haven't audited any other DBs to see if that's the case anywhere else. Thanks!

[brettwooldridge]

I've already committed this change and a test case this morning (well, morning here in Tokyo).

[brmeyer]

Great, thanks for the quick response!