Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inability to use custom executor #106

Closed
minecrafter opened this issue Jul 9, 2014 · 4 comments
Closed

Inability to use custom executor #106

minecrafter opened this issue Jul 9, 2014 · 4 comments

Comments

@minecrafter
Copy link

With the environment I will soon work with, I will no longer be able to create threads, and am required to use an ExecutorService. I scanned through the HikariCP source code and found that the code uses multiple executors.

Ideally the new executor setting would be in HikariConfig.

Thanks!

@chrisvest
Copy link

@brettwooldridge To share experience... I tried adding such a feature to Stormpot last year, but abandoned it because the possible failure modes of a user-supplied Executor are too numerous, and too deep in the bowels of the pool; dead-locks from bounded queues, rejected executions, delayed executions, caller-runs, etc.

@brettwooldridge
Copy link
Owner

@chrisvest I tend to agree. @minecrafter what kind of restricted environment is this? Surely there must be other components, web servers, etc. that are creating threads -- very few frameworks/libraries permit user-supplied ExecutorServices/ThreadPools because of the issues outlined by @chrisvest .

@minecrafter
Copy link
Author

This no longer applies to me.

@chrisvest, thanks for explaining in more detail about the perils of allowing users to supply their own executors.

@ams2990
Copy link
Contributor

ams2990 commented Jul 10, 2014

@minecrafter, I'd still be interested in hearing about this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants