Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoolName is overriden in HikariConfig.validate() #101

Closed
jondavidnd1 opened this issue Jun 27, 2014 · 1 comment
Closed

PoolName is overriden in HikariConfig.validate() #101

jondavidnd1 opened this issue Jun 27, 2014 · 1 comment
Labels

Comments

@jondavidnd1
Copy link

If you use the HikariDataSource(HikariConfig configuration) constructor the first step (configuration.validate()) overrides any pre-configured poolName at line 682 of HikariConfig:

poolName = "HikariPool-" + poolNumber++;

This looks like it should be:

if (poolName == null) {
poolName = "HikariPool-" + poolNumber++;
}

I'm using HikariCP 1.4.0

@brettwooldridge
Copy link
Owner

This is already fixed in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants