Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing expiration #874

Open
kingonly opened this issue Apr 10, 2024 · 3 comments · Fixed by #883
Open

Missing expiration #874

kingonly opened this issue Apr 10, 2024 · 3 comments · Fixed by #883
Assignees
@erdemyerebasmaz

Comments

@kingonly
Copy link
Member

Screenshot_20240409-132304
@erdemyerebasmaz erdemyerebasmaz self-assigned this Apr 12, 2024
@erdemyerebasmaz erdemyerebasmaz mentioned this issue Apr 13, 2024
Merged
@kingonly
Copy link
Member Author

The expiration time is now missing completely in the latest build
Screenshot_20240414-184538
Screenshot_20240414-184529

@kingonly kingonly reopened this Apr 14, 2024
@erdemyerebasmaz
Copy link
Collaborator

erdemyerebasmaz commented Apr 15, 2024 •
edited
Loading

Hey @kingonly,
Latest build was for

I can't reproduce locally with a build that has changes from #883.

Pending Completed
image image

I'll trigger a new build that includes all the latest changes later today.

@kingonly
Copy link
Member Author

kingonly commented Apr 15, 2024 •
edited
Loading

I run an Android build yesterday: https://github.com/breez/c-breez/actions/runs/8679841465

I have it installed, and I don't see the expiration time on a pending payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erdemyerebasmaz erdemyerebasmaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not display expiration field for payments that are no longer pending breez/c-breez
2 participants
@erdemyerebasmaz @kingonly