Does not support Laravel 6

[alenamm]

Hello!

I tried to install this package on laravel 6 today and got rejected.

Could you please fix?

Thanks in advance,

Alena

[frankgraave]

Hi @brezzhnev

I wanted to make an atlassian connect app using Laravel 6 as well. So I thought I'd give it a go to see if I could update this to all the latest stuff. But then I found out you were busy yourself with a new release 😅 haha.

However, I could at least show you what I've done in my branch here: https://github.com/frankgraave/atlassian-connect-core/commit/e9f694395df3750f1dd80bfd96af7c03749c5c98

I have 5 Errors and 4 Warnings left in the unit tests. Here's the output:

Testing started at 21:48 ...
/usr/bin/php /Users/frankgraave/Projects/atlassian-connect-core/vendor/phpunit/phpunit/phpunit --configuration /Users/frankgraave/Projects/atlassian-connect-core/phpunit.xml --teamcity
PHPUnit 8.4.1 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.8
Configuration: /Users/frankgraave/Projects/atlassian-connect-core/phpunit.xml


GuzzleHttp\Exception\RequestException : Error Communicating with Server
 /Users/frankgraave/Projects/atlassian-connect-core/tests/Clients/JWTClientTest.php:39

Exception : Class for the paginator alias "undefined" could not be found
 /Users/frankgraave/Projects/atlassian-connect-core/src/Http/Clients/JWTClient.php:250
 /Users/frankgraave/Projects/atlassian-connect-core/src/Http/Clients/JWTClient.php:180
 /Users/frankgraave/Projects/atlassian-connect-core/tests/Clients/JWTClientTest.php:241

assertArraySubset() is deprecated and will be removed in PHPUnit 9.

assertArraySubset() is deprecated and will be removed in PHPUnit 9.

assertArraySubset() is deprecated and will be removed in PHPUnit 9.

AtlassianConnectCore\Exceptions\PaginationException : HTTP Client should be defined
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:212
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:334
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:290
 /Users/frankgraave/Projects/atlassian-connect-core/tests/Pagination/PaginatorTest.php:21

AtlassianConnectCore\Exceptions\PaginationException : Request URL should be defined
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:216
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:334
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:290
 /Users/frankgraave/Projects/atlassian-connect-core/tests/Pagination/PaginatorTest.php:34

AtlassianConnectCore\Exceptions\PaginationException : Pagination type is undefined or invalid
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:208
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:334
 /Users/frankgraave/Projects/atlassian-connect-core/src/Pagination/Paginator.php:290
 /Users/frankgraave/Projects/atlassian-connect-core/tests/Pagination/PaginatorTest.php:47

assertArraySubset() is deprecated and will be removed in PHPUnit 9.

Time: 346 ms, Memory: 26.00 MB

ERRORS!
Tests: 44, Assertions: 84, Errors: 5, Warnings: 4.

Process finished with exit code 2

I'm not 100% sure, but I think these might be related to the broken method of Route::getRoutes()->refreshNameLookups(); inside the ServiceProvider.php file on line 73. I have no idea how to replace that one...

Maybe this is somewhat useful for you, maybe not, you can decide! 😄

Cheers, Frank

[breart]

Hey @frankgraave,

That is a really weird error, please make sure your environment is properly configured.

I'm pretty sure the method is not broken, the Route facade basically doesn't have all his methods described in the DocBlock.

When I run tests (L6) on TravisCI, it works just fine:
https://travis-ci.org/brezzhnev/atlassian-connect-core/builds/603588658

[breart]

Added support in version v1.3.0. There are breaking changes for lower Laravel versions.