Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Functions In A Class? #13

Open
EpicVoyage opened this issue Feb 23, 2015 · 2 comments
Open

Organize Functions In A Class? #13

EpicVoyage opened this issue Feb 23, 2015 · 2 comments

Comments

@EpicVoyage
Copy link

I like this project but need the code organized as a class that does not create globally-scoped functions and variables. If I made the necessary changes, would a pull request be considered?

@brcontainer
Copy link
Owner

Note: There are no global variables.

Yes I am developing a new project that will make the html2canvas-php-proxy support for mvc, mmvc, hmvc with routes (because currently it does not support).

Even if I move up the code for a class, it still would not support projects that use "routes".

It's almost done, I believe that 8 more days to complete all the tests. :)

@EpicVoyage
Copy link
Author

That sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants