Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching on quote from say command #695

Open
c-hudson opened this issue Apr 24, 2019 · 1 comment
Open

Matching on quote from say command #695

c-hudson opened this issue Apr 24, 2019 · 1 comment

Comments

@c-hudson
Copy link

The do_say function passes double quotes to notify_except in unicode. This makes it hard (impossible?) to match against the double quote produced by do_say in mushcode. I was able to proove the issue by replacing the unicode double quote with a simple escaped double quote in the do_say function. 

Mushcode:
&foo object = ^":say # %1
@set object = monitor

Example:
say foo <-- doesn't match
say foo " bar <-- matches

@lashtear
Copy link
Contributor

It should be feasible to match the unicode dquote in the regex, but I'd have to look up the syntax-- so yes, hard.

I'm thinking these should probably regex match on NFKC normalized versions, but that isn't likely a sane default, and is rather nontrivial without libicu...

Alternatively, regex character classes (e.g. [:quote:] or something) might handle this reasonably gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants