Skip to content
This repository has been archived by the owner on Mar 19, 2020. It is now read-only.

Automated browser-laptop builds sometimes crashing in TP #13

Closed
bbondy opened this issue Nov 12, 2016 · 7 comments
Closed

Automated browser-laptop builds sometimes crashing in TP #13

bbondy opened this issue Nov 12, 2016 · 7 comments

Comments

@bbondy
Copy link
Member

bbondy commented Nov 12, 2016

screenshot 2016-11-12 00 28 09

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Nov 12, 2016

@bbondy what are those tests? Could I run them? It looks like a corrupted buffer for deserialization.

@bbondy
Copy link
Member Author

bbondy commented Nov 12, 2016

they are just tests that start the browser, do some task and then close the browser. They download TP on startup like it is normal to do. So you suspect the file somehow gets corrupted?

@bbondy
Copy link
Member Author

bbondy commented Nov 12, 2016

but it also happened I seen on dev channel recently, and so it seems like probably not corrupted data file.

@bbondy
Copy link
Member Author

bbondy commented Nov 12, 2016

Why does it go inside HashSet deserialize and then back into ST_FIRST_PARTY_HOST deserialize? I am a bit confused about the stack because of that.

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Nov 12, 2016

It is all ok to me with a callstack. HashSet is a set of ST_FIRST_PARTY_HOST objects. So it calls deserialize for each object inside it.

@SergeyZhukovsky
Copy link
Member

I'm going to try deserialize with an existing .dat file in a loop.

@SergeyZhukovsky
Copy link
Member

Fixed memory corruption using XCode memory sanitizer. Please try the new version with your tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants