Ensure we convert binance-smart-chain to binance_smart_chain (#93)

* Ensure we convert binance-smart-chain to binance_smart_chain * Bump version to 1.14.1
brave · Nov 2, 2023 · ceb3f18 · ceb3f18
1 parent 03c7e5e
commit ceb3f18
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "token-lists",
-  "version": "1.14.0",
+  "version": "1.14.1",
   "description": "Manages custom token lists for Brave Wallet",
   "dependencies": {
     "@metamask/contract-metadata": "git+https://[email protected]/MetaMask/contract-metadata.git",

diff --git a/scripts/util.cjs b/scripts/util.cjs
@@ -431,12 +431,6 @@ const generateDappListsForChain = async (chain) => {
       return filteredDapp
     })
 
-    // Replace 'binance-smart-chain' with 'binance_smart_chain' so it plays well
-    // with the browser JSON parser.
-    if (chain === 'binance-smart-chain') {
-      chain = 'binance_smart_chain'
-    }
-
     return dapps
   }
 
@@ -456,7 +450,14 @@ const generateDappLists = async () => {
   ]
   const dappLists = {}
   for (let chain of chains) {
-    dappLists[chain] = await generateDappListsForChain(chain)
+    const dapps = await generateDappListsForChain(chain)
+    // Replace 'binance-smart-chain' with 'binance_smart_chain' so it plays well
+    // with the browser JSON parser.
+    if (chain === 'binance-smart-chain') {
+      chain = 'binance_smart_chain'
+    }
+
+    dappLists[chain] = dapps
   }
 
   return dappLists