Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension: True Key #9330

Closed
jonathansampson opened this issue Jun 8, 2017 · 3 comments
Closed

Extension: True Key #9330

jonathansampson opened this issue Jun 8, 2017 · 3 comments
Labels
feature/extensions feature/password-manager fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Jun 8, 2017

Extension: True Key

image

Needed APIs:

chrome.browser

  • chrome.browserAction.onClicked
  • chrome.browserAction.setBadgeBackgroundColor
  • chrome.browserAction.setIcon

chrome.contextMenus

chrome.cookies

chrome.extension

chrome.privacy

  • chrome.privacy.services

chrome.runtime

chrome.storage

  • chrome.storage.local

chrome.tabs

chrome.windows

@cezaraugusto
Copy link
Contributor

+++++++++++++++

@nickytonline
Copy link

nickytonline commented Jun 22, 2017

@jonathansampson

Just an update, since we last talked, after my successful POC for getting True Key to work in Brave. I've started to do the real integration with Brave for the True Key extension while your team works on this issue.

I have a branch in my forked repo that is not ready for a PR to be thrown up yet as this issue is still open and there's still some stuff I'll need to confirm with my work, but this is what I have so far (including E2E and unit tests), https://github.com/brave/browser-laptop/compare/master...nickytonline:feature/add-true-key-extension?expand=1&w=1

screen shot 2017-06-22 at 12 15 16 am

@bsclifton
Copy link
Member

When we move to brave-core (which is just around the corner), we should have full support for extensions. Stay tuned 😄

@bsclifton bsclifton added the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Aug 24, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/extensions feature/password-manager fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix
Projects
None yet
Development

No branches or pull requests

4 participants