Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Always fallback to en_US for spellchecking when no lang is available on Linux #6967

Closed
alexwykoff opened this issue Feb 1, 2017 · 2 comments

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Feb 1, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Spellcheck underline did not display in 0.13.1

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested all platforms, regression on Linux

  • Brave Version (revision SHA):
    Discovered in 0.13.1, regression started in 0.13.0

  • Steps to reproduce:

    1. visit www.wordcounter.net
    2. misspell some words in the input field
    3. check for underlines
  • Actual result:
    Currently no underlines or context menu suggestions appear

  • Expected result:
    Misspelled words should be underlined, right-clicking on the word should give suggested alternatives.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

screen shot 2017-01-31 at 8 40 17 pm

screen shot 2017-01-31 at 8 42 20 pm

  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Feb 2, 2017

This is actually working the same for me in 0.12.15 and 0.13.0 if you have default lang en_US configured, but for me I had en_CA and so it wasn't working in both 0.12.15 and 0.13.0. I did a fix to always fallback to en_US. I would have thought you'd of been on en_US though. So let's see if it fixes it for you too, but it definitely works and fixes it for me.

@bbondy bbondy closed this as completed in c82af5a Feb 2, 2017
@bbondy bbondy changed the title regression: spellcheck missing since 0.13.0 for linux builds Always fallback to en_US for spellchecking (matters most on Linux) Feb 2, 2017
@bbondy bbondy changed the title Always fallback to en_US for spellchecking (matters most on Linux) Always fallback to en_US for spellchecking when no lang is available Feb 3, 2017
@bbondy bbondy changed the title Always fallback to en_US for spellchecking when no lang is available Always fallback to en_US for spellchecking when no lang is available on Linux Feb 3, 2017
@bbondy
Copy link
Member

bbondy commented Feb 3, 2017

This never worked even on 0.12.15 and before by the way.
The original issue reported here is being fixed in
#7015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants