Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Advance settings button should be disabled till Brave wallet is created #4981

Closed
srirambv opened this issue Oct 20, 2016 · 4 comments
Closed

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Advance setting button is clickable when wallet is being created which makes no point until the wallet is actually created

Expected behavior:
Advance settings button should be disabled till Brave wallet is created

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    0.12.6 Preview 1
  • Steps to reproduce:
    1. Do a new install of the preview build
    2. Enable payments, Advance settings button is shown which can be clicked
    3. After wallet is created, delete all ledger.* files from session folder, advance button is still clickable which makes no sense.
  • Screenshot if needed:
  • Any related issues:
@srirambv srirambv added this to the 0.12.6dev milestone Oct 20, 2016
@bbondy bbondy removed this from the 0.12.6dev milestone Oct 21, 2016
@bbondy
Copy link
Member

bbondy commented Oct 22, 2016

@mrose17 for triage but I just didn't want it in 0.12.6 so remove that.

@mrose17 mrose17 added this to the 0.12.8dev milestone Oct 22, 2016
@mrose17
Copy link
Member

mrose17 commented Oct 22, 2016

@bbondy - thanks for the heads-up

@mrose17 mrose17 modified the milestones: 1.1.0, 0.12.8dev Oct 25, 2016
@mrose17 mrose17 modified the milestones: 0.12.11, 1.1.0 Nov 8, 2016
@mrose17
Copy link
Member

mrose17 commented Nov 17, 2016

@srirambv - it's kind of hard for me to think this is a problem. if someone starts deleting files underneath the browser, then i think that we can't really view that as something to guard against.

however, i'll add some bullet-proofing...

@mrose17
Copy link
Member

mrose17 commented Nov 17, 2016

it turns out that this was fixed by @jkup in 7e0d8ed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants