Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide Advanced Settings button when Brave Payments is disabled #4801

Merged
merged 1 commit into from
Oct 15, 2016
Merged

Hide Advanced Settings button when Brave Payments is disabled #4801

merged 1 commit into from
Oct 15, 2016

Conversation

willy-b
Copy link
Contributor

@willy-b willy-b commented Oct 14, 2016

Most of the base tests in test/components/ledgerPanelTest.js are failing for me (e.g. enabling / disabling payments). I'm working on this.

  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Open Brave
  2. Open Brave Preferences -> Payments tab
  3. When Payments is disabled, observe that there is no "Advanced Settings" button in upper right
  4. Click the Payments toggle, observe "Advanced Settings" appears when Payments are enabled
  5. Click toggle again and confirm the "Advanced Settings" button is hidden again

fixes #4790

@bsclifton bsclifton added this to the 0.12.5dev milestone Oct 15, 2016
@bsclifton bsclifton self-assigned this Oct 15, 2016
@bsclifton
Copy link
Member

LGTM 😄 I tested it out locally too, works great

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced setting button should be hidden when payments is disabled
3 participants