This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
added release notes for 0.12.1 #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,30 @@ | |||
| # Changelog | |||
|
|
|||
| ## [0.12.1](https://github.com/brave/browser-laptop/releases/v0.12.1dev) | |||
| - (todo) | |||
| - Added Malay (Malaysia) language. ([#3843](https://github.com/brave/browser-laptop/issues/3843)) | |||
| - Added extensions. ([#3926](https://github.com/brave/browser-laptop/issues/3926))([#3867](https://github.com/brave/browser-laptop/issues/3867))([#2224](https://github.com/brave/browser-laptop/issues/2224)) | |||
There was a problem hiding this comment.
This is misleading and makes the reader think we have new extensions that are added, which is not the case, if it was we woul say which ones.
The first one is an about:extensions page
The last 2 are the same but should be more description, something like Added support for extension action buttons for password managers.
I'd put the Malay language at the bottom of the added list since it isn't applicable to everyone.
alexwykoff
force-pushed
the
0_12_1_release_notes
branch
from
c16c3f8 to
48d3947
Compare
|
@alexwykoff Is it okay that all strings after |
|
Yes seems like a markdown mistake, pls fix that as well @alexwykoff |
| @@ -1,7 +1,30 @@ | |||
| # Changelog | |||
|
|
|||
| ## [0.12.1](https://github.com/brave/browser-laptop/releases/v0.12.1dev) | |||
| - (todo) | |||
| - Added about:extensions page. ([#3926](https://github.com/brave/browser-laptop/issues/3926)) | |||
| - Added support for extension action buttons for password managers. ([#3867](https://github.com/brave/browser-laptop/issues/3867))([#2224](https://github.com/brave/browser-laptop/issues/2224)) | |||
There was a problem hiding this comment.
this one before about:extensions page
updated the notes updated markdown rendering of slack link
|
Nice, thanks! |
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at release notes for 0.12.1