-
Notifications
You must be signed in to change notification settings - Fork 973
Conversation
the value was being kept in a cache that was being read, but not written… no longer.
console.log('\nupdatePublisherInfo: ' + JSON.stringify(underscore.omit(publisherInfo, [ '_internal' ]))) | ||
data = [] | ||
publisherInfo.synopsis.forEach((entry) => { | ||
data.push(underscore.extend(underscore.omit(entry, [ 'faviconURL' ]), { faviconURL: entry.faviconURL && '...' })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the "real" string tends to be a long base64 value. all we really need to know is whether a value is present or not, the "..."
serves that purpose... otherwise, you get a lot of scrolling in the console window with very little useful content.
@mrose17 btw if you use |
@bbondy - true. however, i generally prefer not to auto-close an issue unless i created it... this allows the person who actually crated the issue to verify that it's fixed... |
@mrose17 please follow the process of closing issues when they are complete on master. Sometimes there are multiple commits and QA has it's own process. It would be too confusing to leave things open for testing and that is not the process we're following for this project. It doesn't scale well. Thanks. |
@mrose17 please ping me or @alexwykoff in case you need QA ;-) |
the value was being kept in a cache that was being read, but not written… no longer.
also, fix a small typo in
docs/state.md
this is the fix for #3480
auditor: @diracdeltas