Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

LastPass doesn't load extension properly when choosing for first time #3109

Closed
scot30 opened this issue Aug 11, 2016 · 11 comments
Closed

LastPass doesn't load extension properly when choosing for first time #3109

scot30 opened this issue Aug 11, 2016 · 11 comments
Assignees
Labels
duplicate Issue has already been reported feature/password-manager

Comments

@scot30
Copy link

scot30 commented Aug 11, 2016

Right-clicking in the window used to have a LastPass item at the bottom of the menu that comes up, and that LastPass menu item is gone - so no way to access my LastPass Vault or manually select a password to enter if the password doesn't autofill. I've also noticed that a message comes up at the top of the window asking if I want Brave to remember the password every time a password is entered on a site, even though I have LastPass selected as the password manager in the settings. If this is a new site I want to save a password for, I get the question asking if I want Brave to save the password and I also get the question asking if I want to save it in LastPass.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS X 10.11.6
  • Brave Version: 0.11.4
@bsclifton
Copy link
Member

@scot30 would you be able to change your password manager to something else... Then change it back to LastPass? Let me know if that changes anything. I tested quite a few scenarios, I wonder what happened. If it still does happen and you are open to sharing your session file, I can walk you through a secure way to get it to me so that I can dig deeper

Please let me know- thanks 😄

@bsclifton
Copy link
Member

bsclifton commented Aug 11, 2016

@scot30 If you wanted to share your session file, you can shoot it over to me at [email protected]

@scot30
Copy link
Author

scot30 commented Aug 12, 2016

I switched to Brave as the password manager, and then switched back to LastPass. That seems to have fixed it. Thanks!! ??

[--- Commented from Asana.com
#commenter brad richter
---[aa]

@scot30 scot30 closed this as completed Aug 12, 2016
@luixxiul
Copy link
Contributor

IIRC I noticed the same issue. 1) select LastPass for the first time, 2) blank page, 3) select the default manager, 4) select LastPass, 5) settings page. So let's leave this open, thanks @scot30

@luixxiul luixxiul reopened this Aug 12, 2016
@bbondy bbondy reopened this Aug 13, 2016
@bsclifton
Copy link
Member

@luixxiul can you explain your steps in more detail?

I cleared my session to ensure everything is fresh and added console logs and tried to reproduce but was unable to.

@bsclifton bsclifton added the needs-info Another team member needs information from the PR/issue opener. label Aug 13, 2016
@luixxiul
Copy link
Contributor

luixxiul commented Aug 13, 2016

Will you move AppData\Roaming\brave to other place temporarily and try again? It shall reproduce the error. Here is the screenshot:
clipboard01

cc: @bridiver

@bsclifton
Copy link
Member

@luixxiul interesting... on Mac, it works great. This appears to be Windows only.

When session is empty and you choose LastPass, the blank window which immediately opens is:
chrome-extension://hdokiejnpimakedhajhdlcegeplioahd/tabDialog.html?dialog=createAccountSimple

I don't see any errors in the console (content or electron dev tools).

When the change to active PW manager happens, it triggers the extension to load via a listener on the AppStore:
https://github.com/brave/browser-laptop/blob/master/app/extensions.js#L198

This does load in the sense that it tries to pull up the page. I wonder why that page does not load?

@bridiver
Copy link
Collaborator

the actual loading of that page depends on messages that are sent between it and the extension background page. There may be some slight difference on Windows

@bridiver
Copy link
Collaborator

personally I think it's a little fragile and I might even consider it a LastPass bug because the page also won't load in any browser if you try to navigate to it directly or if you reload it after it has loaded correctly, but we should make it work at least as well as it does on Chrome

@bsclifton bsclifton changed the title 0.11.4 Update Removed LastPass menu item when right-clicking LastPass doesn't load extension properly when choosing for first time Aug 18, 2016
@BCSWowbagger
Copy link

BCSWowbagger commented Aug 18, 2016

This appears to be linked to #2936 (as well as #2916 and #2901). Based on a report in #2901, this is affecting at least one Macintosh computer.

@bsclifton
Copy link
Member

Closing this issue as a dupe of #2936

@bsclifton bsclifton added duplicate Issue has already been reported feature/password-manager and removed needs-info Another team member needs information from the PR/issue opener. OS/Windows labels Aug 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issue has already been reported feature/password-manager
Projects
None yet
Development

No branches or pull requests

7 participants