Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

The position of bookmarks on the toolbar shouldn't be preserved after re-bookmarking #2447

Closed
luixxiul opened this issue Jul 11, 2016 · 3 comments
Closed

The position of bookmarks on the toolbar shouldn't be preserved after re-bookmarking #2447

luixxiul opened this issue Jul 11, 2016 · 3 comments
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 11, 2016 •
edited
Loading

Tests plan

  1. Bookmark https://twitter.com
  2. Bookmark about:about
  3. Move twitter bookmark to the right
  4. Clear twitter bookmark
  5. Open https://twitter.com in a new tab
  6. Bookmark twitter again
  7. Make sure the twitter appears to the right, not left

Describe the issue you encountered: The position of bookmarks on the toolbar shouldn't be preserved when re-bookmarking a previously bookmarked site.
@neeklamy
Copy link
Contributor

It’s the title that gets saved too, try renaming a bookmark, then toggling the bookmark off and on. The bookmark always comes back with the same title that it was changed to.

@bsclifton
Copy link
Member

bsclifton commented Sep 7, 2016 •
edited
Loading

Title fixed w/ #3641

This is a great one for folks wanting to get their feet wet 😄

File of interest is going to be siteUtil, specifically the addSite method. The reason it has the previous position is because the sites array keeps the entry, even after removing (it doubles as a history entry). Deleting the bookmark only removes the tag

@luixxiul luixxiul added this to the contributor backlog milestone Dec 23, 2016
@luixxiul luixxiul added the bug label May 1, 2017
@luixxiul luixxiul removed this from the contributor backlog milestone May 1, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 7, 2017

Closing for QA on 0.20.x where many other bugs related with bookmarks will be fixed.

@luixxiul luixxiul closed this as completed Nov 7, 2017
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Nov 7, 2017
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@neeklamy @luixxiul @bsclifton @srirambv @LaurenWags