From f7576e981130709d48e798657b943da16402ae47 Mon Sep 17 00:00:00 2001 From: Anthony Tseng Date: Tue, 11 Oct 2016 23:58:49 -0400 Subject: [PATCH] Do not override handlers of rowAttributes when multiSelect is disabled fix #4695 Auditors: @bsclifton Test Plan: 1. Go to about:preferences#search 2. Should be able to change search engine --- js/components/sortableTable.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/components/sortableTable.js b/js/components/sortableTable.js index 6f5dbc855e0..f85d653fcf5 100644 --- a/js/components/sortableTable.js +++ b/js/components/sortableTable.js @@ -218,8 +218,8 @@ class SortableTable extends ImmutableComponent { : rowAttributes.className) + (this.sortingDisabled ? ' no-sort' : '') } - onClick={this.props.multiSelect ? this.onClick : undefined} - onContextMenu={this.props.multiSelect ? this.onContextMenu : undefined}>{entry} + onClick={this.props.multiSelect ? this.onClick : rowAttributes.onClick} + onContextMenu={this.props.multiSelect ? this.onContextMenu : rowAttributes.onContextMenu}>{entry} : null }) }