From 8a34b772c83cdf559071bc2d29cf3827aa8ef2a6 Mon Sep 17 00:00:00 2001 From: yan Date: Wed, 24 Feb 2016 12:54:36 -0800 Subject: [PATCH] Return null redirectURL for HTTPS Everywhere excluded URLs When redirectURL is set to the original URL, this can cause the browser to throw net::ERR_TOO_MANY_REDIRECTS and not load the URL. Caused foxnews.com to break. Auditors: @bbondy --- app/httpsEverywhere.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/httpsEverywhere.js b/app/httpsEverywhere.js index da8242c36ca..2d5cd1ba6c4 100644 --- a/app/httpsEverywhere.js +++ b/app/httpsEverywhere.js @@ -102,7 +102,7 @@ function applyRuleset (url, applicableRule) { for (i = 0; i < exclusion.length; ++i) { exclusionPattern = new RegExp(exclusion[i].$.pattern) if (exclusionPattern.test(url)) { - return url + return null } } }