Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Restyle buttons according to updated mockups #536

Open
antonok-edm opened this issue Sep 12, 2019 · 1 comment · May be fixed by #541
Open

Restyle buttons according to updated mockups #536

antonok-edm opened this issue Sep 12, 2019 · 1 comment · May be fixed by #541

Comments

@antonok-edm
Copy link
Collaborator

The current button designs are outdated.

They should be updated to look like the ones in this mockup:

Button Specs

In dark mode, "Default" style buttons should be styled as follows: white text and #c2c4cf border, Hover style should be #FF7654 bold, weight: 700 text and #FF7654 border. Focused treatment is white text, #FF7654 border with 3px #FF7654 40% alpha border. and pressed state is #FF7654 text and #FF7654 border with 3px #FF7654 40% alpha border

"Primary" style buttons are identical between dark and light themes.

@antonok-edm
Copy link
Collaborator Author

Regarding existing button styles at https://brave.github.io/brave-ui/?path=/story/components--button, as per conversation with @karenkliu:

  • "Subtle" style can be removed
  • Disabled buttons should be styled the same as enabled, but with 40% opacity
  • Primary button style with default gray color can be removed
  • "Warning" style can be removed
  • "Rewards" button isn't really in line with the design system, but could still be an accent button type for now.

@antonok-edm antonok-edm linked a pull request Sep 18, 2019 that will close this issue
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant