-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NFT lists scrollable #1380
Comments
if possible, add cached paging support to the back-end, so that once the front-end makes the first rquest, and it is returned, then we pre-fetch/cache the second page, and try to maintain 3 pages in the cache for the address we are asking about (one back, one current, one forward). |
I believe this can be done all in the frontend by adding the required paging parameters to URLs like brave-talk/src/components/web3/api.ts Lines 104 to 106 in 173f35e
(except caching). |
great! i suspect it would be good to review the brave-talk-server code to make sure it sanitizes the query params so that only |
Hmm no I'm not sure we care to do that for client requests. Proxy code is https://github.com/search?q=repo%3Abrave%2Fanon-proxy%20simplehash&type=code |
OK, let's not worry about the query parameters. Let's just make the lists scrollable. |
We have entered an interesting era of NFTs wherein you can subscribe to services that send you NFTs daily (or more frequently). This effectively makes the "show the latest 50 NFTs" display strategy unhelpful.
Sadly, it is time to retrieve all the NFTs (filtered or not on
spam_score
) and present them to the user in a scrollable list.The text was updated successfully, but these errors were encountered: