Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed label for data saved amount #5643

Merged
merged 1 commit into from
May 25, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented May 24, 2020

Resolves brave/brave-browser#9915

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 24, 2020
@samartnik samartnik added this to the 1.11.x - Nightly milestone May 24, 2020
@samartnik samartnik requested a review from SergeyZhukovsky May 24, 2020 14:17
@samartnik samartnik self-assigned this May 24, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik force-pushed the android_data_saved_label_change branch from 32a738e to 94e094a Compare May 25, 2020 15:11
@samartnik samartnik merged commit 269bf3c into master May 25, 2020
@samartnik samartnik deleted the android_data_saved_label_change branch May 25, 2020 17:43
brave-builds pushed a commit that referenced this pull request May 25, 2020
brave-builds pushed a commit that referenced this pull request May 25, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.11.28 Nightly build
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Estimated bandwidth savings in NTP suggest bits rather than bytes
3 participants