Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing deps for brave_shields/common #4499

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

petemill
Copy link
Member

@petemill petemill commented Feb 4, 2020

Fixes master build error on android caused by #4269 (and therefore needs uplifting to 1.5.x)

Fix brave/brave-browser#8056

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill self-assigned this Feb 4, 2020
@petemill petemill force-pushed the fix-shields-android branch from abb568e to 058aa65 Compare February 4, 2020 20:34
@petemill
Copy link
Member Author

petemill commented Feb 4, 2020

version mismatch!!

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and compiles on Android now.

@petemill petemill merged commit 7bacb52 into master Feb 4, 2020
@petemill petemill deleted the fix-shields-android branch February 4, 2020 20:58
petemill added a commit that referenced this pull request Feb 4, 2020
Missing deps for brave_shields/common
bbondy added a commit that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] master build error
3 participants