Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport importer bugfixes (uplift to 1.1.x) #4024

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Backport importer bugfixes (uplift to 1.1.x) #4024

merged 1 commit into from
Nov 20, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 19, 2019 •
edited by bsclifton
Loading

Uplift of #3837
Fixes brave/brave-browser#6521

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 19, 2019
@brave-builds brave-builds added this to the 1.1.x - Beta milestone Nov 19, 2019
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv November 19, 2019 16:46
@bsclifton
Copy link
Member

bsclifton commented Nov 20, 2019 •
edited
Loading

macOS tests failed because of brave/brave-browser#6515 - other platforms passed fine 👍 Marking as CI passed 👍

bsclifton
bsclifton approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit ce9d4e7 into 1.1.x Nov 20, 2019
@bsclifton bsclifton deleted the pr3837_ie_firefox_import_1.1.x branch November 20, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @bsclifton @brave-browser-releases