Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Japan to ads #3172

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Add support for Japan to ads #3172

merged 1 commit into from
Aug 14, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 14, 2019

Fixes brave/brave-browser#5656
Requires #3171
Requires #3158

Submitter Checklist:

Test Plan:

  • Confirm untargeted ads are shown for Japan

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 23c7a44 into master Aug 14, 2019
@tmancey tmancey deleted the issues/5656 branch August 14, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Japan to ads
2 participants