Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ads onboarding for users who have not signed up to ads for new regions #3171

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 14, 2019

Fixes brave/brave-browser#5655
Requires #3158
Requires #3172

Submitter Checklist:

Test Plan:

  • Confirm ads onboarding is shown for new regions when upgrading
  • Confirm ads onboarding is shown for new regions for fresh installs

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 0.71.x - Nightly milestone Aug 14, 2019
@tmancey tmancey requested review from emerick and NejcZdovc August 14, 2019 10:16
@tmancey tmancey self-assigned this Aug 14, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show ads onboarding for users who have not signed up to ads for new regions
2 participants