Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad matching for ads that are not categorized #3158

Merged
merged 5 commits into from
Aug 13, 2019
Merged

Ad matching for ads that are not categorized #3158

merged 5 commits into from
Aug 13, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 13, 2019

Fixes brave/brave-browser#5183
Requires #3171
Requires #3172

Submitter Checklist:

Test Plan:

  • Confirm targeted ads for PARENT-CHILD page classifications are served for the United States of America, Canada, United Kingdom, Germany, France, Australia, New Zealand and Ireland
  • Confirm targeted ads for PARENT page classifications are served for the United States of America, Canada, United Kingdom, Germany, France, Australia, New Zealand and Ireland
  • Confirm untargeted ads are served for the United States of America, Canada, United Kingdom, Germany, France, Australia, New Zealand and Ireland if no eligible ads are available
  • Confirm untargeted ads are served for Argentina, Austria, Brazil, Switzerland, Chile, Colombia, Denmark, Ecuador, Israel, India, Italy, Korea, Mexico, Netherlands, Peru, Philippines, Poland, Sweden, Singapore, Venezuela and South Africa

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey
Copy link
Collaborator Author

tmancey commented Aug 13, 2019

@jsecretan @lukemulks The above issue is development complete, we need a list of untargeted regions for initial release. Thanks

kylehickinson
kylehickinson previously approved these changes Aug 13, 2019
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS changes look good

emerick
emerick previously approved these changes Aug 13, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

@@ -62,7 +62,7 @@ void ChangeLocale(

`ClassifyPage` should be called when a page has loaded in the current browser tab, and the HTML is available for analysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name in comment needs an update...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

emerick
emerick previously approved these changes Aug 13, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kylehickinson
kylehickinson previously approved these changes Aug 13, 2019
…ombia, Denmark, Ecuador, Israel, India, Italy, Korea, Mexico, Netherlands, Peru, Philippines, Poland, Sweden, Singapore, Venezuela and South Africa to Ads
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 13, 2019

Added support for Argentina, Austria, Brazil, Switzerland, Chile, Colombia, Denmark, Ecuador, Israel, India, Italy, Korea, Mexico, Netherlands, Peru, Philippines, Poland, Sweden, Singapore, Venezuela and South Africa to Ads (untargeted)

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ad matching for ads that are not categorized
3 participants