Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync reset reenable #3038

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Sync reset reenable #3038

merged 2 commits into from
Jul 31, 2019

Conversation

AlexeyBarabash
Copy link
Contributor

Submitter Checklist:

Fixes brave/brave-browser#3190.

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Android
    • iOS
    • Linux
    • macOS
    • Windows
  • Verified that these changes pass automated tests (unit, browser, security tests) on
    • iOS
    • Linux
    • macOS
    • Windows
[237/237] BraveRewardsBrowserTest.ProcessPendingContributions (TIMED OUT)
1 test timed out:
    BraveRewardsBrowserTest.ProcessPendingContributions (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2150)

Test Plan:

Use STR from brave/brave-browser#3190 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

darkdh
darkdh previously approved these changes Jul 30, 2019
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash
Copy link
Contributor Author

@darkdh could you please re-approve, as I had to make force-push to deal with CI

@AlexeyBarabash AlexeyBarabash requested a review from darkdh July 31, 2019 12:18
@AlexeyBarabash AlexeyBarabash merged commit 5e293e8 into master Jul 31, 2019
@AlexeyBarabash AlexeyBarabash deleted the sync_reset_reenable branch July 31, 2019 16:16
darkdh added a commit that referenced this pull request Jul 31, 2019
darkdh added a commit that referenced this pull request Aug 9, 2019
darkdh added a commit that referenced this pull request Aug 9, 2019
darkdh added a commit that referenced this pull request Aug 15, 2019
darkdh added a commit that referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Warning message not being displayed, when click on Confirm Sync code without any code added
2 participants