Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tab mute button of inactive tab is not clickable #13043

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Fixed tab mute button of inactive tab is not clickable #13043

merged 1 commit into from
Apr 19, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 17, 2022 •
edited
Loading

fix brave/brave-browser#22081

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong requested a review from a team as a code owner April 17, 2022 03:35
@simonhong simonhong self-assigned this Apr 17, 2022
@simonhong simonhong force-pushed the tab_audio_button_click branch from 6cd852a to 87c34fb Compare April 17, 2022 03:47
@simonhong simonhong requested a review from nullhook April 17, 2022 04:03
@simonhong simonhong force-pushed the tab_audio_button_click branch from 87c34fb to 243e7ee Compare April 17, 2022 06:50
nullhook
nullhook approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonhong simonhong force-pushed the tab_audio_button_click branch 2 times, most recently from 8a997a1 to 7eee98c Compare April 19, 2022 11:36
@simonhong simonhong requested a review from goodov April 19, 2022 11:36
@simonhong simonhong force-pushed the tab_audio_button_click branch from 7eee98c to 7dadfb3 Compare April 19, 2022 11:38
@simonhong
Fixed tab mute button of inactive tab is not clickabl
07f49f9 
fix brave/brave-browser#22081

Fixed by calculating tab selectable region properly by
GetWidthOfLargestSelectableRegionBrave() as we moved alert button
to left side.
@simonhong simonhong added the CI/skip Do not run CI builds (except noplatform) label Apr 19, 2022
@simonhong simonhong force-pushed the tab_audio_button_click branch from 7dadfb3 to 07f49f9 Compare April 19, 2022 22:39
@simonhong
Copy link
Member Author

Merged as IPFSCookieStore test cases are only failed and it's known issue.

@simonhong simonhong merged commit bd74933 into master Apr 19, 2022
@simonhong simonhong deleted the tab_audio_button_click branch April 19, 2022 22:40
@simonhong simonhong added this to the 1.39.x - Nightly milestone Apr 19, 2022
simonhong added a commit that referenced this pull request Apr 25, 2022
@simonhong
Merge pull request #13043 from brave/tab_audio_button_click
89e8039 
Fixed tab mute button of inactive tab is not clickable
@simonhong simonhong mentioned this pull request Apr 25, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@nullhook nullhook nullhook approved these changes

Assignees

@simonhong simonhong

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging this pull request may close these issues.

Tab mute icon (to mute/unmute audio) is not clickable for tabs in the background
3 participants
@simonhong @goodov @nullhook