Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Site Permissions for brave://wallet Route #11603

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

Changed WalletOrigin value to fix disabling the Site Permissions button in the Wallet Panel when the active tabs origin is chrome://wallet

Resolves brave/brave-browser#20094

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Before:

Screen.Recording.2021-12-14.at.2.42.00.PM.mov

After:

Screen.Recording.2021-12-14.at.3.02.54.PM.mov

@Douglashdaniel Douglashdaniel added this to the 1.35.x - Nightly milestone Dec 15, 2021
@Douglashdaniel Douglashdaniel merged commit a36db31 into master Dec 15, 2021
@Douglashdaniel Douglashdaniel deleted the disable-site-permissions-for-wallet-routes branch December 15, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow viewing Site Permissions Panel for brave://wallet route
2 participants