Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTest doesn't support _ underscore in test names well #42456

Closed
cdesouza-chromium opened this issue Nov 22, 2024 · 1 comment
Closed

GTest doesn't support _ underscore in test names well #42456

cdesouza-chromium opened this issue Nov 22, 2024 · 1 comment
Assignees
@cdesouza-chromium
Labels
dev-concern OS/Desktop QA/No release-notes/exclude

Comments

@cdesouza-chromium
Copy link
Contributor

Description

We must remove all uses of _ in our test names as this could lead to bugs. This has been already flagged in chromium as well[1].

[1] https://issues.chromium.org/issues/377144451
@cdesouza-chromium cdesouza-chromium self-assigned this Nov 22, 2024
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 22, 2024
@cdesouza-chromium
[CodeHealth] Remove underscores from test names
c55f3b9 
GoogleTest reserves underscores for special purposes, like DISABLED_,
PRE_, and others, and can generate invalid C++ identifiers when test
names contain underscore.

This is a mechanical change that should have no functional effect.

Resolves brave/brave-browser#42456
@cdesouza-chromium cdesouza-chromium mentioned this issue Nov 22, 2024
Closed
24 tasks
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 22, 2024
@cdesouza-chromium
[CodeHealth] Remove underscores from test names
e321616 
GoogleTest reserves underscores for special purposes, like DISABLED_,
PRE_, and others, and can generate invalid C++ identifiers when test
names contain underscore.

This is a mechanical change that should have no functional effect.

Resolves brave/brave-browser#42456
cdesouza-chromium added a commit to brave/brave-core that referenced this issue Nov 22, 2024
@cdesouza-chromium
[CodeHealth] Remove underscores from test names
f4743d7 
GoogleTest reserves underscores for special purposes, like DISABLED_,
PRE_, and others, and can generate invalid C++ identifiers when test
names contain underscore.

This is a mechanical change that should have no functional effect.

Resolves brave/brave-browser#42456
@cdesouza-chromium
Copy link
Contributor Author

Won't fix https://groups.google.com/a/chromium.org/g/chromium-dev/c/KxzyXKv7adQ

@cdesouza-chromium cdesouza-chromium closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdesouza-chromium cdesouza-chromium

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CodeHealth] Remove underscores from test names brave/brave-core
1 participant
@cdesouza-chromium