Fixes text for AC box

Resolves brave/brave-browser#6483
brave · Oct 16, 2019 · 6e0cccb · 6e0cccb
1 parent 448e597
commit 6e0cccb
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 14 deletions.
diff --git a/.storybook/locale.ts b/.storybook/locale.ts
@@ -232,7 +232,7 @@ const locale: Record<string, string> = {
   siteBannerConnectedText: 'This creator has not yet signed up to receive contributions from Brave users. Your browser will keep trying to contribute until they verify, or until 90 days have passed.',
   sites: 'sites',
   tellOthers: 'Tell others about your tip.',
-  supportedSites: 'Sites viewed',
+  viewedSites: 'Sites Viewed',
   thankYou: 'Thank You!',
   termsOfService: 'Terms of Service',
   optOutTooltip: 'You will no longer receive\nads from this category',

diff --git a/browser/ui/webui/brave_webui_source.cc b/browser/ui/webui/brave_webui_source.cc
@@ -254,7 +254,7 @@ void CustomizeWebUIHTMLSource(const std::string &name,
         { "contributionVisitSome",  IDS_BRAVE_REWARDS_LOCAL_CONTR_VISIT_SOME },
         { "contributionMinTime",  IDS_BRAVE_REWARDS_LOCAL_CONTR_MIN_TIME },
         { "contributionMinVisits",  IDS_BRAVE_REWARDS_LOCAL_CONTR_MIN_VISITS },
-        { "contributionAllowed",  IDS_BRAVE_REWARDS_LOCAL_CONTR_ALLOWED },
+        { "contributionOther",  IDS_BRAVE_REWARDS_LOCAL_CONTR_OTHER },
         { "contributionShowNonVerified",  IDS_BRAVE_REWARDS_LOCAL_CONTR_SHOW_NON_VERIFIED },        // NOLINT
         { "contributionVideos",  IDS_BRAVE_REWARDS_LOCAL_CONTR_ALLOW_VIDEOS },
         { "contributionVisit1",  IDS_BRAVE_REWARDS_LOCAL_CONTR_VISIT_1 },
@@ -571,7 +571,7 @@ void CustomizeWebUIHTMLSource(const std::string &name,
         { "serviceTextWelcome", IDS_BRAVE_UI_SERVICE_TEXT_WELCOME },
         { "serviceTextReady", IDS_BRAVE_UI_SERVICE_TEXT_READY },
         { "showAll", IDS_BRAVE_UI_SHOW_ALL },
-        { "supportedSites", IDS_BRAVE_UI_SUPPORTED_SITES },
+        { "viewedSites", IDS_BRAVE_UI_VIEWED_SITES },
         { "termsOfService", IDS_BRAVE_UI_TERMS_OF_SERVICE }
       }
     }, {

diff --git a/components/brave_rewards/resources/page/components/contributeBox.tsx b/components/brave_rewards/resources/page/components/contributeBox.tsx
@@ -196,7 +196,7 @@ class ContributeBox extends React.Component<Props, State> {
               <div data-value='10'>{getLocale('contributionVisit10')}</div>
             </Select>
           </ControlWrapper>
-          <ControlWrapper text={getLocale('contributionAllowed')}>
+          <ControlWrapper text={getLocale('contributionOther')}>
             <Checkbox
               value={{
                 contributionNonVerified: contributionNonVerified,

diff --git a/components/brave_rewards/resources/ui/components/modalContribute/__snapshots__/spec.tsx.snap b/components/brave_rewards/resources/ui/components/modalContribute/__snapshots__/spec.tsx.snap
@@ -62,7 +62,7 @@ exports[`ModalContribute tests basic tests matches the snapshot 1`] = `
                       selected={true}
                       type="contribute"
                     >
-                      MISSING: supportedSites (0)
+                      MISSING: viewedSites (0)
                     </div>
                   </div>
                   <div

diff --git a/components/brave_rewards/resources/ui/components/modalContribute/index.tsx b/components/brave_rewards/resources/ui/components/modalContribute/index.tsx
@@ -120,7 +120,7 @@ export default class ModalContribute extends React.PureComponent<Props, {}> {
                 onChange={onTabChange}
                 tabIndexSelected={activeTabId}
                 tabTitles={[
-                  this.getTabTitle('supportedSites', numSites),
+                  this.getTabTitle('viewedSites', numSites),
                   this.getTabTitle('excludedSites', numExcluded)
                 ]}
               />

diff --git a/components/brave_rewards/resources/ui/stories/settings/contributeBox.tsx b/components/brave_rewards/resources/ui/stories/settings/contributeBox.tsx
@@ -74,7 +74,7 @@ class ContributeBox extends React.Component<{}, State> {
                 <div data-value='60'>{locale.contributionVisit10}</div>
               </Select>
             </ControlWrapper>
-            <ControlWrapper text={locale.contributionAllowed}>
+            <ControlWrapper text={locale.contributionOther}>
               <Checkbox
                 value={{
                   contributionNonVerified: true,

diff --git a/components/brave_rewards/resources/ui/stories/settings/fakeLocale.ts b/components/brave_rewards/resources/ui/stories/settings/fakeLocale.ts
@@ -11,7 +11,7 @@ const locale = {
   adsFreq: 'Ad Frequency',
   adsMode: 'Ad mode',
   adsTitle: 'Brave Ads',
-  contributionAllowed: 'What should be allowed?',
+  contributionOther: 'Other settings',
   contributionDesc: 'A simple way to support content creators. Set monthly allowance and browse normally. Your favorite sites (content sites only) receive your contributions automatically. You can exclude sites from funding here.',
   contributionMinTime: 'Minimum page time before logging a visit',
   contributionMinVisits: 'Minimum visits for publisher relevancy',

diff --git a/components/brave_rewards/resources/ui/stories/settingsMobile/contributeBoxMobile.tsx b/components/brave_rewards/resources/ui/stories/settingsMobile/contributeBoxMobile.tsx
@@ -143,7 +143,7 @@ class ContributeBoxMobile extends React.Component<Props, State> {
             ]}
           />
         </ControlWrapper>
-        <ControlWrapper text={locale.contributionAllowed}>
+        <ControlWrapper text={locale.contributionOther}>
           <Checkbox
             value={{
               contributionNonVerified: true,

diff --git a/components/brave_rewards/resources/ui/stories/settingsMobile/fakeLocale.ts b/components/brave_rewards/resources/ui/stories/settingsMobile/fakeLocale.ts
@@ -10,7 +10,7 @@ const locale = {
   adsFreq: 'Ad Frequency',
   adsMode: 'Ad mode',
   adsTitle: 'Brave Ads',
-  contributionAllowed: 'What should be allowed?',
+  contributionOther: 'Other settings',
   contributionDesc: 'A simple way to support content creators. Set monthly allowance and browse normally. Your favorite sites (content sites only) receive your contributions automatically. You can exclude sites from funding here.',
   contributionHideAll: 'Hide all',
   contributionMinTime: 'Minimum page time before logging a visit',

diff --git a/components/resources/brave_components_strings.grd b/components/resources/brave_components_strings.grd
@@ -228,7 +228,7 @@
       <message name="IDS_BRAVE_REWARDS_LOCAL_DEVICE_OFFLINE" desc="">The device is offline, please try again later.</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_MONTHLY" desc="">Monthly Payment</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_NEXT_DATE" desc="">Next contribution date</message>
-      <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_SITES" desc="">Supported sites</message>
+      <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_SITES" desc="">Sites viewed</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_DONAT_TITLE" desc="">Tips</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_DONAT_DESC" desc="">Tip content creators directly as you browse. You can also set up recurring monthly tips so you can support sites continuously.</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_MONTHLY_CONTRIBUTION_TITLE" desc="">Monthly Contributions</message>
@@ -249,8 +249,8 @@
       <message name="IDS_BRAVE_REWARDS_LOCAL_TOKENS" desc="">tokens</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_MIN_TIME" desc="">Minimum page time before logging a visit</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_MIN_VISITS" desc="">Minimum visits for publisher relevancy</message>
-      <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_ALLOWED" desc="">What should be allowed?</message>
-      <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_SHOW_NON_VERIFIED" desc="">Only show verified sites in Auto-Contribute list</message>
+      <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_OTHER" desc="">Other settings</message>
+      <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_SHOW_NON_VERIFIED" desc="">Show non-verified sites in list</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_ALLOW_VIDEOS" desc="">Allow contribution to videos</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_VISIT_1" desc="">1 visit</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_CONTR_VISIT_5" desc="">5 visits</message>
@@ -583,7 +583,7 @@
       <message name="IDS_BRAVE_UI_REWARDS_EXCLUDED_TEXT_1" desc="">You've excluded</message>
       <message name="IDS_BRAVE_UI_REWARDS_EXCLUDED_TEXT_2" desc="">sites from Auto-Contribute.</message>
       <message name="IDS_BRAVE_UI_SHOW_ALL" desc="">Show All</message>
-      <message name="IDS_BRAVE_UI_SUPPORTED_SITES" desc="">Sites viewed</message>
+      <message name="IDS_BRAVE_UI_VIEWED_SITES" desc="">Sites Viewed</message>
 
       <message name="IDS_BRAVE_UI_GRANT_FINISH_TITLE_ADS" desc="Title on final grant screen for Ads">Brave Ads Rewards!</message>
       <message name="IDS_BRAVE_UI_GRANT_FINISH_TEXT_ADS" desc="Text on final grant screen for UGP">Your rewards grant from Brave Ads is on its way.</message>