Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6434: Using vpython for lint (0.70.x) #6648

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Fix 6434: Using vpython for lint (0.70.x) #6648

merged 1 commit into from
Oct 29, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 29, 2019

Uplift request for #6638
Fixes #6434

Submitter Checklist:

Test Plan:

  1. Uninstall httplib2 pip uninstall httplib2
  2. Update package.json to checkout httplib2_lint in brave-core
  3. run: npm run init
  4. in brave-core: git checkout -b TEMP_LINT
  5. run: npm run lint and verify one error shows up

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde requested a review from a team October 29, 2019 16:13
@jumde jumde self-assigned this Oct 29, 2019
@jumde jumde added the QA/No label Oct 29, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 7b25918 into 0.70.x Oct 29, 2019
@bsclifton bsclifton deleted the 0.70.x_lint branch October 29, 2019 16:27
@bsclifton bsclifton added this to the 0.70.x - Release milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants