Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6434: Using vpython for lint #6638

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Fix 6434: Using vpython for lint #6638

merged 1 commit into from
Oct 29, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 28, 2019

fixes #6434

Submitter Checklist:

Test Plan:

  1. Uninstall httplib2 pip uninstall httplib2
  2. Update package.json to checkout httplib2_lint in brave-core
  3. run: npm run init
  4. in brave-core: git checkout -b TEMP_LINT
  5. run: npm run lint and verify one error shows up

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde changed the title [WIP] Using vpython for lint Fix 6434: Using vpython for lint Oct 28, 2019
@jumde jumde self-assigned this Oct 28, 2019
@jumde jumde added the QA/No label Oct 28, 2019
@jumde jumde force-pushed the httplib2 branch 2 times, most recently from 642b151 to 7a56a1e Compare October 28, 2019 19:45
@bsclifton
Copy link
Member

When running (after both npm run init and npm run sync -- --all), I get the following (macOS):

clifton@iMac-Pro (httplib2 *=) $ npm run lint

> [email protected] lint /Users/clifton/Documents/brave-browser3
> node ./scripts/commands.js lint

/Users/clifton/Documents/brave-browser3/src/brave: vpython /Users/clifton/Documents/brave-browser3/scripts/lint.py --project_root=/Users/clifton/Documents/brave-browser3/src --base_branch=origin/master
Traceback (most recent call last):
  File "/Users/clifton/Documents/brave-browser3/scripts/lint.py", line 15, in <module>
    import git_cl
  File "/Users/clifton/Documents/brave-browser3/vendor/depot_tools/git_cl.py", line 46, in <module>
    import gerrit_util
  File "/Users/clifton/Documents/brave-browser3/vendor/depot_tools/gerrit_util.py", line 37, in <module>
    from six.moves import urllib
ImportError: No module named six.moves

@jumde jumde force-pushed the httplib2 branch 2 times, most recently from 6ad604f to ebcde77 Compare October 28, 2019 23:36
bsclifton
bsclifton previously approved these changes Oct 29, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ran after your last change; worked great! 😄

@jumde jumde merged commit 2953678 into master Oct 29, 2019
@jumde jumde deleted the httplib2 branch October 29, 2019 16:02
@jumde jumde added this to the 0.73.x - Nightly milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint issue
3 participants