Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] [hackerone] #876192 - Cookie stealing #9818

Closed
jumde opened this issue May 18, 2020 · 3 comments · Fixed by brave/brave-core#5841
Closed

[Android] [hackerone] #876192 - Cookie stealing #9818

jumde opened this issue May 18, 2020 · 3 comments · Fixed by brave/brave-core#5841
Assignees
@jumde
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include sec-high security
Milestone
1.12.x - Release #1

Comments

@jumde
Copy link
Contributor

jumde commented May 18, 2020 •
edited
Loading

https://hackerone.com/reports/876192

Test Plan

Specified here: brave/brave-core#5841
@jumde jumde added the OS/Android Fixes related to Android browser functionality label May 18, 2020
@jumde jumde self-assigned this Jun 14, 2020
@jumde jumde mentioned this issue Jun 15, 2020
Merged
32 tasks
@jumde jumde added this to the 1.12.x - Nightly milestone Jun 15, 2020
@srirambv
Copy link
Contributor

  • Verification passed on OnePlus 6T with Android 10 running 1.12.111 x64 build
  • Verification passed on Samsung Tab A with Android 10 running 1.12.111 x64 build

This was referenced Aug 11, 2020
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Aug 18, 2020
Closed
@jumde
Copy link
Contributor Author

jumde commented Aug 29, 2020

Re-opening since this was reverted: brave/brave-core#6530 - This change breaks PDF reader on android. Details here: https://bravesoftware.slack.com/archives/C0816QH3R/p1598646322107500

@jumde jumde reopened this Aug 29, 2020
@jumde jumde removed this from the 1.12.x - Release milestone Aug 29, 2020
@srirambv srirambv mentioned this issue Aug 31, 2020
Closed
@srirambv
Copy link
Contributor

@jumde logged #11520 as this issue was already part of 1.12.x milestone.

@srirambv srirambv added this to the 1.12.x - Release milestone Aug 31, 2020
@kjozwiak kjozwiak mentioned this issue Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include sec-high security
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fix 9818: Do not use root-path for file-path brave/brave-core
3 participants
@diracdeltas @jumde @srirambv