-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate/bad confirmations retry logic #9242
Comments
Verification passed on
Test Case 1 (Create confirmation fails with 400 BAD REQUEST):
Test Case 2 (Create confirmation fails with 500 INTERNAL SERVER ERROR):
Test Case 3 (Create confirmation succeeds with 201 CREATED):
Test Case 4 (Fetch payment token fails with 404 NOT FOUND):
confirmations.json with failed confirmations
After disabling Charles overwrite. Confirmation was successfully redeemed
confirmations.json failed confirmation queue becomes empty after successful confirmation
Test Case 5 (Fetch payment token fails with 500 INTERNAL SERVER ERROR):
confirmations.json - After successful retry, failed confirmation queue becomes empty and estimated BAT value will be assigned to
Test Case 6:
Test Case 7 (Fetch payment token succeeds with 200 OK):
Verified passed with
Test Case 1 - PASSED
Test Case 2 - PASSED
Test Case 3 - PASSED
Test Case 4 - PASSED
Failed Confirmations Queue:
First item in the queue was retried successfully:
Second item in queue retried successfully as well:
Test Case 5 - PASSED
All failed confirmations retried successfully:
Test Case 6 - PASSED
Test Case 7 - PASSED
Verification passed on
Verified test plan from brave/brave-core#5260 Verified Test Case 1 (Create confirmation fails with 400 BAD REQUEST):
Test Case 2 (Create confirmation fails with 500 INTERNAL SERVER ERROR):
Test Case 3 (Create confirmation succeeds with 201 CREATED):
Test Case 4 (Fetch payment token fails with 404 NOT FOUND): confirmations.json with failed confirmations
After disabling Charles overwrite. Confirmation was successfully redeemed
Test Case 5 (Fetch payment token fails with 500 INTERNAL SERVER ERROR):
After disabling Charles overwrite. Confirmation was successfully redeemed
Test Case 6
Test Case 7 (Fetch payment token succeeds with 200 OK):
|
Description
Duplicate/bad confirmations retry logic
Steps to Reproduce
confirmations.json
underconfirmations/failed_confirmations
Actual result:
Duplicate confirmations are retried indefinitely
Expected result:
Duplicate confirmations should not be retried indefinitely
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: