Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance view state is retained when widget is disabled and re-enabled #9238

Closed
srirambv opened this issue Apr 15, 2020 · 2 comments
Closed
Assignees

Comments

@srirambv
Copy link
Contributor

Description

Balance view state is retained when widget is disabled and re-enabled

Steps to Reproduce

  1. Connect to Binance account on the widget
  2. Balance view is hidden by default
  3. Enable balance view to show
  4. Hide Binance widget
  5. Re-enable Binance widget, balance view state is retained

Actual result:

Hide balance view when widget is disabled and re-enabled

Expected result:

Balance view state should be reset when widget is disabled/enabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @ryanml @bbondy @jamesmudgett

@srirambv srirambv added suggestion design A design change, especially one which needs input from the design team QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support feature/widgets labels Apr 15, 2020
@ryanml ryanml self-assigned this Apr 15, 2020
@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 15, 2020
@ryanml
Copy link
Contributor

ryanml commented Apr 15, 2020

Closing this one as we are going to reset the widget on hide: #9244

@ryanml ryanml closed this as completed Apr 15, 2020
@srirambv
Copy link
Contributor Author

srirambv commented Apr 21, 2020

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified hiding the widget disconnects state and reset
  • Verified hiding via dashboard or via widget menu resets the connected state

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified hiding the widget disconnects state and reset
  • Verified hiding via dashboard or via widget menu resets the connected state

Verification passed on

Brave 1.9.36 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified hiding the widget disconnects state and reset
  • Verified hiding via dashboard or via widget menu resets the connected state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants