[Desktop] Add Block trackers & ads (aggressive) setting to apply cosmetic filtering to 1p items

[pes10k]

Description

by default we have cosmetic filtering that attempts to differentiate 1p and 3p ads, and only block the latter.

Some users would like to do the simpler, "apply all cosmetic filters, always" approach. Basically, just do what uBO does.

This issue would be to modify the current cosmetic filtering to have an option to automatically inject all cosmetic filters, and not do party checks. '

Design

Shields panel

brave://settings

Figma for CSS, layout, sizing: https://www.figma.com/file/3A6F6VrxVahiZFxLr7j7FO/Desktop-Brave-Shields?node-id=16%3A14877

[pes10k]

The implementation could be pretty simple:

1. Add a content / per-site shields setting for cosmetic filtering (off, only 3p {default}, all)
2. add a code path in the cosmetic filtering content script that, when the above is in the "all" mode, injects all matching rules (not just 3p ones)

[BrendanEich]

I like even more minimal yet viable MVPs. Per https://twitter.com/myphs/status/1233110060903075844?s=20 what many want is the "uBO me globaly please" setting. That would be a single setting, could even start with brave:flags or better internal URL and no official settings UX. But what would it flip internally?

[karenkliu]

Designs for brave://settings added and dropdown option typo fixed.

[btlechowski]

Verification passed on

Brave	1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5481
Verified default setting

Verified default setting in brave://settings/shields

Verified aggressive setting in Brave Shields Panel works:

Verified aggressive setting in brave://settings/shields works:

Verified allowing all trackers and ads in Brave Shields works as expected

Verified allowing all trackers and ads in brave://settings/shields works as expected
Verified page is reloaded when changing the setting in Brave Shields.
Verified that the setting in brave://settings/shields is not updated by changes to the Shields panel

---

Verified passed using

Brave	1.11.90 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Allow cosmetic filtering to also be applied to 1p items brave-core#5481
• Note, brave://settings changes were superseded by [Desktop] Make grammar consistent for titles and drop downs on brave://settings/shields #9975

• Also, site from test plan was no longer available, used https://web.archive.org/web/20200515013413/http://raymondhill.net/ublock/tiles1.html instead

• Left global Trackers & ads blocking to be Standard (default). Confirmed shields inherited this value. Confirmed left tile was green, right tile was red.

• Set global Trackers & ads blocking to be Aggressive. Confirmed shields inherited this value. Confirmed left tile was green, right tile was green.

• Set global Trackers & ads blocking to be Disabled. Confirmed shields inherited this value. Confirmed left tile was red, right tile was red.

• Left global Trackers & ads blocking to be Standard (default). Changed per site value to be Trackers & ads blocked (aggressive). Confirmed left tile was green, right tile was green. Confirmed global setting remained Standard.

• Left global Trackers & ads blocking to be Standard (default). Changed per site value to be Allow all trackers & ads. Confirmed left tile was red, right tile was red. Confirmed global setting remained Standard.

• Set global Trackers & ads blocking to be Aggressive. Changed per site value to be Trackers & ads blocked (standard). Confirmed left tile was green, right tile was red. Confirmed global setting remained Aggressive.

---

Verification passed on

Brave | 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
-- | --
Revision | e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS | Windows 10 OS Version 1903 (Build 18362.900)

• Verified test plan from Allow cosmetic filtering to also be applied to 1p items brave-core#5481

Verified default setting in brave://settings/shields

Default site shield settings

When sites shield settings are set to Trackers & ads blocked (standard) left tile is displayed in Green and Right tile is displayed in Red

When sites shield settings are set to Trackers & ads blocked (aggressive) left tile and right tiles are displayed in Green

When site shield settings are set to Allow all trackers & ads left and right tiles are displayed in Red

When global shield setting for Trackers & ads blocked is set to Standard left tile is displayed in Green and Right tile is displayed in Red

When global shield setting for Trackers & ads blocked is set to Aggressive left and right tiles are displayed in Green

When global shield setting for Trackers & ads blocked is set to Disable left and right tiles are displayed in Red