Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats text need to have more contrast with background images for better visibilty #8250

Closed
srirambv opened this issue Feb 14, 2020 · 9 comments
Assignees

Comments

@srirambv
Copy link
Contributor

Description

Stats text need to have more contrast with background images for better visibilty

Actual result:

image

Expected result:

Better visibility of text on images

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.6.24 Chromium: 80.0.3987.100 (Official Build) nightly (64-bit)
Revision 3f00c26d457663a424865bbef1179f72eec1b9fe-refs/branch-heads/3987@{#864}
OS macOS Version 10.15.1 (Build 19B88)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? May be
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @GeetaSarvadnya @btlechowski to check on other platforms as well

@srirambv srirambv added bug feature/user-interface All UI related design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude labels Feb 14, 2020
@srirambv
Copy link
Contributor Author

Issue is worse on SI and when hovered over stats
image

@bsclifton
Copy link
Member

@bradleyrichter @karenkliu can you advise a color change that would make sense for this? Also- Estimated Bandwidth Saved is new- does that look OK?

@rebron
Copy link
Collaborator

rebron commented Feb 14, 2020

@srirambv @bsclifton We need to hide Estimated bandwidth saved for desktop as this stat will be used on mobile to replace HTTPS Upgrades on mobile.

@srirambv I'm going to ahead and rename this issue.

@rebron
Copy link
Collaborator

rebron commented Feb 14, 2020

Actually, I'll file a separate issue and close this one out as invalid.

This is the issue that added the bandwidth stat.
#7783

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Feb 14, 2020
@rebron
Copy link
Collaborator

rebron commented Feb 14, 2020

Related: #8256 Still in discussion if bandwidth makes sense and replaces HTTPS Upgrades or if it's a different stat altogether that replaces HTTPS Upgrades. Net of it is we'll only have three stats to show on NTP, not four.

@rebron rebron closed this as completed Feb 14, 2020
@rebron rebron added closed/invalid and removed QA/Yes bug closed/invalid design A design change, especially one which needs input from the design team feature/user-interface All UI related needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. release-notes/exclude labels Feb 14, 2020
@srirambv
Copy link
Contributor Author

@rebron the issue was for Text contrast for Estimated time saved and not for Estimated Bandwidth Saved. The font contrast still needs to be fixed so reopening it as Estimated Bandwidth Saved will be logged separately

@srirambv srirambv reopened this Feb 17, 2020
@srirambv srirambv added bug design A design change, especially one which needs input from the design team feature/new-tab QA/Yes and removed closed/invalid labels Feb 17, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 17, 2020

@srirambv The new wallpapers seem to have addressed the text contrast issue?
Not sure if we have more to do here.

cc: @karenkliu in case you had other thoughts.

Screen Shot 2020-04-17 at 8 25 13 AM

@rebron rebron self-assigned this Apr 17, 2020
@karenkliu
Copy link

@rebron This issue should have been fixed with #8256

We still have this issue open to replace HTTPS Upgrades with Bandwidth Saved but there should not be any text legibility issues with that either #8969 (comment)

@rebron
Copy link
Collaborator

rebron commented May 14, 2020

Closing. Fixed with #8969

@rebron rebron closed this as completed May 14, 2020
@rebron rebron added closed/invalid and removed QA/Yes bug design A design change, especially one which needs input from the design team feature/new-tab labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants