Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification badge is retained even after claiming grants from BR panel #8239

Closed
GeetaSarvadnya opened this issue Feb 13, 2020 · 1 comment · Fixed by brave/brave-core#4745

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 13, 2020

Description

Notification badge is retained even after claiming grants from BR panel

Steps to Reproduce

  1. Clean profile 1.4.x launch using brave.exe --rewards=staging=true,reconcile-interval=5
  2. Enable rewards
  3. Click on BAT logo notification
  4. Clear the captcha test in the BR panel itself
  5. Click on settings which navigate to brave://rewards page
  6. Notification badge is not removed from the BAT logo in the URL bar

Actual result:

Notification badge is retained even after claiming grants from BR panel
image

Badge notification retained ecen afterclaiming UGP grants

Expected result:

Notification badge should be removed after claiming grants from BR panel

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.4.86 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Mar 19, 2020

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
  • Verified the test plan from the description
    image

Verification passed on

Brave 1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS
  • Verified the test plan from the description
    image

Verified passed with

Brave 1.7.73 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment