Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #7840 - After excluding a site from A-C table Show All link is not shown in ac table #8071

Closed
GeetaSarvadnya opened this issue Feb 5, 2020 · 4 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 5, 2020

Description

After excluding a site from A-C table Show All link is not shown in ac table

Steps to Reproduce

  1. Clean profile 1.3.110
  2. Enable rewards
  3. Add a site to a-c table
  4. Exclude the added site by clicking on Trash icon
  5. After excluding a site from A-C table Show All link is not shown

Actual result:

After excluding a site from A-C table Show All link is not shown in ac table
Show All link missing _1 3 110

Expected result:

After excluding a site from A-C table Show All link should be shown in a-c table

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron @masparrow

@GeetaSarvadnya
Copy link
Author

The issue is reproducible in Windows 8.1 (VM) - 1.3.110

@rebron
Copy link
Collaborator

rebron commented Feb 5, 2020

I was able to reproduce using steps in Windows 10 - 1.3.111.
I was NOT able to reproduce using macOS 1.3.111.

@rebron rebron removed this from the 1.3.x - Release milestone Feb 6, 2020
@rebron
Copy link
Collaborator

rebron commented Feb 6, 2020

Clearing 1.3.x milestone.

@GeetaSarvadnya
Copy link
Author

The issue is working fine in 1.4.x beta channel hence closing the issue.

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 6, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants