Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch: use Tor for background requests where possible #804

Open
5 tasks
tildelowengrimm opened this issue Aug 21, 2018 · 1 comment
Open
5 tasks

Switch: use Tor for background requests where possible #804

tildelowengrimm opened this issue Aug 21, 2018 · 1 comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. Epic feature/tor OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@tildelowengrimm
Copy link
Contributor

There's a lot of plumbing needed behind the scenes to make Brave tick. A lot of this background work is mostly-invisible to the user. At the very least, the user isn't sitting there waiting for it to happen. Running those services over Tor would be a great way to further-protect user privacy and deliver on our mission of can't-be-evil rather than don't-be-evil.

As we saw in brave/browser-laptop#14603, there are some users for whom running Tor is undesirable, no matter what. Even with an administrative policy option for disabling Tor completely, it makes sense to be cautious in the deployment of this feature. Perhaps an off-by-default setting which controls all the background services, including those invented later? Once we get confident with it, we could potentially consider this as part of an onboarding or "privacy assistant" flow.

It's worth considering configuring Brave-operated endpoints as onion services. Because of the anonymity provided by Tor, there's little risk to having those endpoints run on third-party infrastructure. Indeed, infrastructure operated this way has little risk of ever accidentally accumulating IP addresses in logs since that information is never disclosed. Single onion services seem like a good fit for this infrastructure. Alec Muffett's Enterprise Onion Toolkit might also be useful. Note though, that this issue is about the browser work — the devops work should be tracked elsewhere when we need it.

Because Tor isn't an option for everyone, we probably can't ever deprecate our clearweb versions of these services. But we can work to provide the best possible experience for those who have the feature enabled — and work to ensure that most users learn about it and have the opportunity to turn turn it on.

Some specific services which we should consider torifying:

  • ledger/rewards services
  • update checks
  • update downloads
  • analytics
  • sync
@tildelowengrimm tildelowengrimm added feature/tor privacy/feature User-facing privacy- & security-focused feature work. labels Aug 21, 2018
@tildelowengrimm tildelowengrimm added this to the Backlog milestone Aug 21, 2018
@tildelowengrimm tildelowengrimm changed the title Switch: use Tor for background requests to Brave-operated services Switch: use Tor for background requests where possible Aug 21, 2018
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Oct 30, 2018
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 28, 2018
@tildelowengrimm
Copy link
Contributor Author

An alternative implementation approach could automatically flip the switch based on activity. If someone opens a private window with Tor and visits a site, then does the same thing a day later: it's probably okay for them to use Tor, and we can give them the privacy benefits of using Tor in the background without them having to find the setting.

On the other hand, once someone manually adjusts the setting at all, nothing else they do should cause the switch to flip. The switch could even be labelled before first use: "Using private windows with Tor will automatically use Tor to protect background connections. Toggle to manually enable or disable this behavior.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@tildelowengrimm tildelowengrimm removed privacy privacy/feature User-facing privacy- & security-focused feature work. labels Jul 10, 2019
@tildelowengrimm tildelowengrimm added Epic design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Jul 25, 2019
@tildelowengrimm tildelowengrimm self-assigned this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. Epic feature/tor OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

3 participants