Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile icon for websites skewed for 16px favicons in Rewards UI #8007

Closed
jonathanKingston opened this issue Feb 2, 2020 · 0 comments · Fixed by brave/brave-core#4474
Closed

Profile icon for websites skewed for 16px favicons in Rewards UI #8007

jonathanKingston opened this issue Feb 2, 2020 · 0 comments · Fixed by brave/brave-core#4474
Assignees
@jonathanKingston
Labels
feature/rewards QA/No release-notes/include
Milestone
1.7.x - Release

Comments

@jonathanKingston
Copy link

Description

Small icons that aren't 24px are stretched for the rewards page.

Steps to Reproduce

  1. Open a new build of Brave
  2. Go to ycombinator.com
  3. Go to chrome://rewards/

Actual result:

Screenshot from 2020-02-02 00-15-33

Expected result:

Vertically centred with new stretched images

Reproduces how often:

Easy once you have a site in your list with a normal sized icon

Brave version (brave://version info)

Latest build on Linux
@jonathanKingston jonathanKingston mentioned this issue Mar 4, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.7.x - Nightly milestone Mar 4, 2020
@NejcZdovc NejcZdovc added the QA/No label Mar 4, 2020
@bsclifton bsclifton changed the title Profile icon for websites skewed for 16px favicons Profile icon for websites skewed for 16px favicons in Rewards UI Mar 4, 2020
@kjozwiak kjozwiak mentioned this issue Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanKingston jonathanKingston

Labels
feature/rewards QA/No release-notes/include
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging a pull request may close this issue.

Fix rewards profile icon skew for small favicons. jonathanKingston/brave-core
3 participants
@jonathanKingston @bsclifton @NejcZdovc