Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave crashes when new sync chain is started at the 2nd time #7982

Closed
GeetaSarvadnya opened this issue Jan 30, 2020 · 1 comment
Closed

Brave crashes when new sync chain is started at the 2nd time #7982

GeetaSarvadnya opened this issue Jan 30, 2020 · 1 comment
Labels
closed/duplicate Issue has already been reported

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 30, 2020

Description

Brave crashes when new sync chain is started at the 2nd time

Steps to Reproduce

Scenario1:

  1. Clean profile 1.3.x
  2. Open Sync
  3. Click on Start a new sync chain
  4. Select Phone/Tablet option
  5. Click on Cancel button in the QR code modal
  6. Remove the desktop device which is listed in the Device Name section in brave://sync page
  7. Click on Start a new sync chain
  8. Brave crashes

Scenario2:

  1. Clean profile 1.3.x
  2. Open Sync
  3. Click on Start a new sync chain
  4. Select Phone/Tablet option
  5. Click on Cancel button in the QR code modal
  6. Remove the desktop device which is listed in the Device Name section in brave://sync page
  7. Click on I have sync code
  8. Enter the sync code which is copied from another device
  9. Brave crashes

Actual result:

Brave crashes when new sync chain is started at the 2nd time
Sync crash issue

Expected result:

Should not be any crash

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.3.105 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @AlexeyBarabash @darkdh @rebron @bsclifton

@GeetaSarvadnya GeetaSarvadnya changed the title Brave crash when new sync chain is started at the 2nd time Brave crashes when new sync chain is started at the 2nd time Jan 30, 2020
@AlexeyBarabash
Copy link
Contributor

Thanks @GeetaSarvadnya
This seems the same as #7412 , fixed with brave/brave-core#4281, now this is in 1.4.x (dev).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

2 participants