Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crypto Wallet to reflect Old DAI changing to SAI #7583

Closed
Pentagrade opened this issue Jan 3, 2020 · 3 comments
Closed

Update Crypto Wallet to reflect Old DAI changing to SAI #7583

Pentagrade opened this issue Jan 3, 2020 · 3 comments

Comments

@Pentagrade
Copy link

Pentagrade commented Jan 3, 2020

Description

The latest versions of Metamask now show Single-Collateral DAI as "SAI" in the wallet and will automatically display Multi-Collateral DAI also if any is contained in the wallet.

Currently to achieve the same result in Crypto Wallet I have to add Multi-Collateral DAI manually. Single-Collateral DAI does appear with the SAI logo however, but uses "DAI" as its token symbol creating confusion as there are now two "DAI" symbols in my wallet.

Please could the behavior from Metamask be pulled across to Crypto Wallet?

Steps to Reproduce

  1. Import a wallet containing Single-Collateral DAI (SAI) and Multi-Collateral DAI (DAI)
  2. Wallet displays DAI (but is actually SAI)

Actual result:

image

A picture from Metamask for comparison after importing the same wallet:
image

Brave version (brave://version info)

Brave 1.4.50 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1903 (Build 18362.476)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes, 1.1.23
  • Can you reproduce this issue with the beta channel? Yes, 1.3.81
  • Can you reproduce this issue with the dev channel? Yes, 1.4.50
  • Can you reproduce this issue with the nightly channel? Yes, 1.5.9

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? When using the latest version of Metamask, No
@srirambv srirambv added feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes release-notes/exclude labels Jan 3, 2020
@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2020

cc: @ryanml does the MM rebase on component 0.1.31 fix this as well?

@bbondy
Copy link
Member

bbondy commented Jan 3, 2020

I think this should be included in the next release, please re-open if not @srirambv.

@bbondy bbondy closed this as completed Jan 3, 2020
@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2020

Verification passed on

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Linux
Component 0.1.34

image


Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.35

image


Verification passed on

Brave 1.5.18 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.35

Screen Shot 2020-01-09 at 12 51 44 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment