Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infura interactions should be behind fastly proxy cache #6614

Closed
ryanml opened this issue Oct 25, 2019 · 4 comments · Fixed by brave/eth-json-rpc-infura#1
Closed

Infura interactions should be behind fastly proxy cache #6614

ryanml opened this issue Oct 25, 2019 · 4 comments · Fixed by brave/eth-json-rpc-infura#1

Comments

@ryanml
Copy link
Contributor

ryanml commented Oct 25, 2019

Server side work completed by @bkero here: https://github.com/brave/devops/pull/1936
Caching should be enabled for each supported network.

Test Plan:
Testing this involves a general regression test of crypto wallet functionality. This includes:

  • Sending/Receiving assets
  • Adding ERC-20 tokens
  • Connecting to and interacting with dApps
  • Ensuring that balances/conversions are accurate and up to date.
@ryanml ryanml added QA/Yes QA/Test-Plan-Specified feature/web3/wallet Integrating Ethereum+ wallet support labels Oct 25, 2019
@ryanml ryanml added this to the Dupe / Invalid / Not actionable milestone Oct 25, 2019
@ryanml ryanml self-assigned this Oct 25, 2019
@kjozwiak
Copy link
Member

@ryanml just curious if there's a reason this is in the Dupe / Invalid / Not actionable milestone?

@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.14.6 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/v0.1.18 with the following build:

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.14.6 (Build 18G95)

Examples:

Screen Shot 2019-10-30 at 11 44 27 PM

@srirambv
Copy link
Contributor

Verification passed on

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Linux
  • Verified using remote component 0.1.18
  • Verified ETH/BAT is sent into a restored MM wallet
  • Verified ETH/BAT is sent into a restored Crypto Wallet
  • Verified sending conversion for ETH/ERC-20 tokens is correct
  • Verified buying via CW works on https://memefactory.io/ with transaction
    image

@kjozwiak
Copy link
Member

Verification PASSED on Win 10 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/v0.1.18 with the following build:

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1809 (Build 17763.805)

Examples:

Annotation 2019-10-31 155534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment