Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Brave UA String via navigator.userAgent on select origins #6441

Closed
jonathansampson opened this issue Oct 11, 2019 · 1 comment
Closed
Labels
browser-laptop-parity priority/P4 Planned work. We expect to get to it "soon".

Comments

@jonathansampson
Copy link
Contributor

Description

Brave currently exposes a custom user agent string in the HTTP request headers for select domains. This does not, however, change the value stored in navigator.userAgent for those same origins.

https://github.com/brave/brave-core/blob/66ceaf3491778f7d9a62f215c8fb47b318c9b181/browser/net/brave_site_hacks_network_delegate_helper.cc#L66-L74

Steps to Reproduce

Go to a whitelisted domain (e.g. duckduckgo.com) and log navigator.userAgent in the console.

Actual result:

Brave token not present.

Expected result:

Brave token should be present, as it is in the request header for the document.

Reproduces how often:

Always.

Brave version (brave://version info)

0.69.132

Other Additional Information:

I believe the requested behavior was present in earlier Muon builds.

@rebron rebron added browser-laptop-parity priority/P4 Planned work. We expect to get to it "soon". labels Oct 18, 2019
@bsclifton
Copy link
Member

bsclifton commented Feb 13, 2020

Closing in favor of #8216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

4 participants