Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The switch Offer to translate pages... is enabled in settings when don't ask me again is selected in Private Tabs #6428

Closed
GeetaSarvadnya opened this issue Oct 11, 2019 · 1 comment · Fixed by brave/brave-core#3673

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 11, 2019

Description

Found while testing #6340

The switch Offer to translate pages... is enabled in settings when don't ask me again is clicked in translate bubble in Private Tabs

Steps to Reproduce

  1. Clean profile 0.69.134
  2. Go to brave://settings/languages and make sure Offer to translate pages that aren't in a language you read is enabled.
  3. Open a Private Window and visit https://www.deutschland.de/de in a new tab
  4. When translate bubble is shown, click don't ask me again
  5. Go back to the settings tab, the switch in step 2 shows as enabled instead of disabled

Actual result:

The switch Offer to translate pages... is enabled in settings when don't ask me again is clicked in translate bubble in Private Tabs

Expected result:

The switch Offer to translate pages... should be disabled in settings when don't ask me again is clicked in translate bubble in PT Tabs

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.69.134 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @yrliou @bsclifton @brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya changed the title The switch Offer to translate pages... is enabled in settings when don't ask me again is clicked in translate bubble in PT Tabs The switch Offer to translate pages... is enabled in settings when don't ask me again is clicked in translate bubble in Private Tabs Oct 11, 2019
@GeetaSarvadnya GeetaSarvadnya changed the title The switch Offer to translate pages... is enabled in settings when don't ask me again is clicked in translate bubble in Private Tabs The switch Offer to translate pages... is enabled in settings when don't ask me again is selected in Private Tabs Oct 11, 2019
@yrliou yrliou self-assigned this Oct 11, 2019
@yrliou yrliou added this to the 0.69.x - Release Hotfix 1 milestone Oct 11, 2019
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 11, 2019

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description

Verified passed with

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from the description

Verified passed with

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment