Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid patching testing_profile.cc #6305

Open
yrliou opened this issue Oct 3, 2019 · 0 comments
Open

Avoid patching testing_profile.cc #6305

yrliou opened this issue Oct 3, 2019 · 0 comments
Labels
dev-concern QA/No

Comments

@yrliou
Copy link
Member

yrliou commented Oct 3, 2019 •
edited
Loading

This is a follow up for brave/brave-core#3319.
To be able to run something in TestingProfile's constructor, we introduced a one-line patch at https://github.com/brave/brave-core/blob/master/patches/chrome-test-base-testing_profile.cc.patch#L9, this issue is to track the work for removing it.
A possible approach suggested by @bridiver is to create a subclass of Profile and do a chromium_src override to let TestingProfile inherit from it.
@yrliou yrliou self-assigned this Oct 3, 2019
@yrliou yrliou removed their assignment Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern QA/No
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yrliou