-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User earns rewards while native macOS notifications are suppressed #5541
Labels
Comments
tmancey
added
bug
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
feature/ads
labels
Aug 5, 2019
Resolved by #3651 |
tmancey
added
closed/duplicate
Issue has already been reported
QA/No
and removed
QA/Yes
labels
Nov 4, 2019
Reopening issue as #3651 did not resolve the issue as we are blocked until Chromium notifications are transitioned to UNUserNotificationCenter |
NejcZdovc
removed
feature/rewards
closed/duplicate
Issue has already been reported
labels
Dec 4, 2019
NejcZdovc
removed
the
priority/P2
A bad problem. We might uplift this to the next planned release.
label
Dec 5, 2019
NejcZdovc
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Dec 5, 2019
tmancey
removed
QA/Yes
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Mar 21, 2020
tmancey
changed the title
Fix user earns while native macOS notifications are suppressed
User earns rewards while native macOS notifications are suppressed
May 3, 2020
Blocked as issue will be closed once #9592 has been implemented |
Closing issue as superseded by #9592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When notifications are disabled for the browser, ad notifications still register as having been displayed and the user is able to earn BAT in spite of never having seen a notification or ad.
Steps to Reproduce
Actual result:
The browser believes it is showing ad notifications from time to time.
Expected result:
The browser ceases to show notifications, or is aware that they aren't visible.
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
0.70.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: