Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User earns rewards while native macOS notifications are suppressed #5541

Closed
tmancey opened this issue Aug 5, 2019 · 7 comments
Closed

User earns rewards while native macOS notifications are suppressed #5541

tmancey opened this issue Aug 5, 2019 · 7 comments

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 5, 2019

Description

When notifications are disabled for the browser, ad notifications still register as having been displayed and the user is able to earn BAT in spite of never having seen a notification or ad.

Steps to Reproduce

  1. Enable Brave Rewards and Ads
  2. Visit System Preferences > Notifications in macOS Settings
  3. Disable notifications for Brave

Actual result:

The browser believes it is showing ad notifications from time to time.

Expected result:

The browser ceases to show notifications, or is aware that they aren't visible.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.70.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@tmancey tmancey added bug feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. feature/ads labels Aug 5, 2019
@Miyayes
Copy link
Collaborator

Miyayes commented Sep 7, 2019

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 11, 2019

@tmancey
Copy link
Contributor Author

tmancey commented Nov 4, 2019

Resolved by #3651

@tmancey tmancey self-assigned this Nov 4, 2019
@tmancey tmancey added the QA/Yes label Nov 4, 2019
@tmancey tmancey modified the milestones: 0.73.x - Nightly, Dupe / Invalid / Not actionable Nov 4, 2019
@tmancey tmancey added closed/duplicate Issue has already been reported QA/No and removed QA/Yes labels Nov 4, 2019
@tmancey tmancey closed this as completed Nov 4, 2019
@tmancey tmancey reopened this Nov 7, 2019
@tmancey
Copy link
Contributor Author

tmancey commented Nov 7, 2019

Reopening issue as #3651 did not resolve the issue as we are blocked until Chromium notifications are transitioned to UNUserNotificationCenter

@NejcZdovc NejcZdovc removed this from the Dupe / Invalid / Not actionable milestone Nov 9, 2019
@NejcZdovc NejcZdovc removed feature/rewards closed/duplicate Issue has already been reported labels Dec 4, 2019
@NejcZdovc NejcZdovc removed the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 5, 2019
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 5, 2019
@tmancey tmancey added QA/Yes and removed QA/No labels Jan 20, 2020
@tmancey tmancey assigned tmancey and unassigned tmancey Jan 22, 2020
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 21, 2020

@tmancey tmancey removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 21, 2020
@tmancey tmancey removed their assignment May 3, 2020
@tmancey tmancey changed the title Fix user earns while native macOS notifications are suppressed User earns rewards while native macOS notifications are suppressed May 3, 2020
@tmancey
Copy link
Contributor Author

tmancey commented May 29, 2020

Blocked as issue will be closed once #9592 has been implemented

@tmancey
Copy link
Contributor Author

tmancey commented Oct 22, 2020

Closing issue as superseded by #9592

@tmancey tmancey closed this as completed Oct 22, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants